Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Amélioration de la validation des champs url #1565

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

madjid-asa
Copy link
Contributor

Quoi ?

Aujourd'hui le contrôle des urls est partiel.

On a des manquements de validation qui ont fait que certaines urls sont passées alors qu'elle n'auraient pas dû.
Ex :

  • http://en cours
  • http://test.fr ou http://test2.fr

Comment ?

Renforcer la vérification du champs en y incluant plusieurs vérifications :

  1. url au bon format
  2. Enregistrement dns existe vraiment
  3. On test qu'on a bien une réponse après une requête http get

@madjid-asa madjid-asa self-assigned this Dec 4, 2024
@madjid-asa madjid-asa changed the title Fix: amélioration de la validation des champs url Fix: Amélioration de la validation des champs url Dec 4, 2024
@madjid-asa madjid-asa changed the title Fix: Amélioration de la validation des champs url fix: Amélioration de la validation des champs url Dec 4, 2024
@SebastienReuiller
Copy link
Contributor

@madjid-asa il te manque une migration j'ai l'impression ;)

@madjid-asa madjid-asa merged commit fb26956 into master Dec 10, 2024
8 checks passed
@madjid-asa madjid-asa deleted the madjid-asa/add-more-controls-on-url-fields branch December 10, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants