Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Migration de l'authentification de token vers un middleware + Sauvegarde des anciennes clés d'apis #1531

Merged
merged 13 commits into from
Nov 27, 2024

Conversation

madjid-asa
Copy link
Contributor

Quoi ?

Migration de l'authentification de token vers un middleware pour migrer progressivement vers une architecture Baerer token.

J'ai profité de cette PR pour sauvegarder les anciens tokens, pour le suivi des stats.

@madjid-asa madjid-asa self-assigned this Nov 20, 2024
@github-actions github-actions bot requested a review from chloend November 20, 2024 16:28
@madjid-asa madjid-asa changed the title fix : Migration de l'authentification de token vers un middleware + Sauvegarde des anciennes clés d'apis fix: Migration de l'authentification de token vers un middleware + Sauvegarde des anciennes clés d'apis Nov 20, 2024
Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trop bien, bravo !
Je me pose la question sur la longueur souhaitable du token, pourquoi on n'irait pas jusqu'à 64 caractères voir plus ? Il y a peut-être des recommandations ?

lemarche/api/authentication.py Outdated Show resolved Hide resolved
@madjid-asa madjid-asa merged commit f37debf into master Nov 27, 2024
8 checks passed
@madjid-asa madjid-asa deleted the madjid-asa/update-api-keys branch November 27, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants