feat: Ajout d'attributs dans Brevo pour les structures #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloend
changed the title
chloend
force-pushed
the
chloend/company-attributes
branch
2 times, most recently
from
b38d41e to
7b0ab70
Compare
SebastienReuiller
requested changes
Nov 20, 2024
chloend
force-pushed
the
chloend/company-attributes
branch
2 times, most recently
from
1c9faa8 to
8482909
Compare
SebastienReuiller
approved these changes
Nov 28, 2024
lemarche/crm/tests.py
Outdated
| self.assertEqual( | ||
| siae_with_recent_stats.tender_detail_contact_click_count_annotated, | ||
| 1, | ||
| "Les clics de contact récents dans les 90 jours devraient être 1", |
There was a problem hiding this comment.
Trop bien les messages sur les asserts !
chloend
force-pushed
the
chloend/company-attributes
branch
3 times, most recently
from
7cd8329 to
d92f5d9
Compare
madjid-asa
requested changes
Dec 4, 2024
lemarche/utils/apis/api_brevo.py
Outdated
| @@ -146,6 +146,7 @@ def create_or_update_company(siae): | |||
| "geo_range": siae.geo_range, | |||
| "app_url": get_object_share_url(siae), | |||
| "app_admin_url": get_object_admin_url(siae), | |||
| **siae.extra_data, # includes completion_rate, tender_email_send_count, etc. | |||
There was a problem hiding this comment.
Tu risque d'inclure des attributs en trop si tu fait ça, vaut mieux les nommé pour éviter d'ajouter d'autres attributs qu'il peut y avoir dans extra_data.
|
|
||
| # extra_data update if needed | ||
| if siae.extra_data != new_extra_data: | ||
| siae.extra_data = new_extra_data |
There was a problem hiding this comment.
extra_data peut contenir d'autres attributs que ceux là, donc en faisant ça t'écrase les anciens attributs ^^ faudrait juste écraser les anciennes clés.
D'ailleurs je pense que les clés ne doivent pas correspondre dans Brevo, faut utiliser une notation de type TAUX_DE_COMPLETION sans accents :)
| @@ -78,6 +79,24 @@ def get_city_filter(perimeter, with_country=False): | |||
| return filters | |||
|
|
|||
|
|
|||
| def count_field(field_name, date_limit): | |||
chloend
force-pushed
the
chloend/company-attributes
branch
from
c3d5e1d to
ae5db36
Compare
madjid-asa
reviewed
Dec 9, 2024
| } | ||
|
|
||
| # extra_data update if needed | ||
| if siae.extra_data != new_extra_data: |
There was a problem hiding this comment.
Suggested change
| if siae.extra_data != new_extra_data: | |
| if siae.extra_data.get('brevo_company_data') != new_extra_data: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Partie 2 de la synchro Brevo, donc suite de la PR1468
Ajout d'attributs dans la liste des Structures dans Brevo.
Pourquoi ?
Pour segmenter les envois d’email marketing, et ne pas multiplier les listes sur Brevo.
Comment ?
En ajoutant 3 attributs dans siae.extra_data :
Enfin, le dictionnaire est initialisé et/ou mis à jour dans la commande
crm_brevo_sync_companies.