Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Github action pour automatiquement remplir les reviewers d'une PR #1265

Merged
merged 4 commits into from
Jun 12, 2024

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Jun 12, 2024

Quoi ?

Similaire à #1042 (PR assignees), mais pour les reviewers.
J'en ai profité pour supprimer l'autre workflow, car celui-ci permet aussi d'auto-assign l'auteur.

Pourquoi ?

Pour éviter de devoir le faire manuellement

Comment ?

Grâce à https://github.com/marketplace/actions/auto-assign-action

Notes

Pourquoi ne pas indiquer la team directement ?

Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@SebastienReuiller SebastienReuiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top ! Tu n'as pas vu un moyen de ne pas mettre l'auteur en reviewer ?

@raphodn
Copy link
Contributor Author

raphodn commented Jun 12, 2024

Top ! Tu n'as pas vu un moyen de ne pas mettre l'auteur en reviewer ?

j'ai l'impression qu'il l'ignore automatiquement ?

@raphodn
Copy link
Contributor Author

raphodn commented Jun 12, 2024

J'ai rajouté un commit pour merger les 2 workflows en 1 seul (ca permet de supprimer celui qui avait été créé dans la PR #1042)

Vu que ce workflow permet d'auto-assign l'auteur :)

@raphodn raphodn merged commit 72c604b into master Jun 12, 2024
9 checks passed
@raphodn raphodn deleted the raphodn/github-workflow-pr-auto-reviewers-team branch June 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants