feat(crm): Management commande de Synchronisation des utilisateurs avec Brevo #1178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madjid-asa
force-pushed
the
madjid-asa/sync-users-brevo-with-crm-id
branch
from
ee0e84a to
9dab3ef
Compare
madjid-asa
changed the title
madjid-asa
force-pushed
the
madjid-asa/sync-users-brevo-with-crm-id
branch
from
72b620e to
0f15839
Compare
raphodn
approved these changes
May 3, 2024
|
|
||
| if not dry_run: | ||
| for user in users_qs: | ||
| brevo_contact_id = None |
There was a problem hiding this comment.
Suggested change
| brevo_contact_id = None | |
| brevo_contact_id = user.brevo_contact_id |
non ? pour skip les users qui sont déjà sync ?
There was a problem hiding this comment.
T'as raison j'ai oublié le cas des users déjà sync, mais je le gère pas comme ça, (voir 5ec2f1e), je check si il correspond à l'id fourni par brevo pour skip
madjid-asa
changed the title
raphodn
reviewed
May 3, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Les utilisateurs existent dans brevo, mais on a pas stocké les identifiants.