Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Brevo): méthode pour créer (et maj) des entreprises (SIAE) #1099

Merged
merged 6 commits into from
Feb 27, 2024
Merged

feat(Brevo): méthode pour créer (et maj) des entreprises (SIAE) #1099

merged 6 commits into from
Feb 27, 2024

Conversation

raphodn
Copy link
Contributor

@raphodn raphodn commented Feb 22, 2024 •
edited
Loading

Quoi ?

API Brevo : nouvelle méthode create_or_update_company

  • permettra d'uploader (et de mettre à jour) notre liste de SIAE sur Brevo
  • la mise à jour est géré en stockant le brevo_company_id dans le nouveau champ extra_data (grâce à feat(SIAE): nouveau champ 'extra_data' #1105)

Testé, ca marche :)

@raphodn raphodn force-pushed the raphodn/brevo-api-siae branch from d309ca6 to c33aee6 Compare February 22, 2024 13:53
@raphodn raphodn changed the base branch from master to raphodn/url-helpers February 22, 2024 13:53
Base automatically changed from raphodn/url-helpers to master February 23, 2024 11:17
@raphodn raphodn force-pushed the raphodn/brevo-api-siae branch 2 times, most recently from db4a09b to be25aef Compare February 26, 2024 15:43
@raphodn raphodn changed the base branch from master to raphodn/siae-extra-data-field February 26, 2024 15:44
@raphodn raphodn changed the title feat(Brevo): API method to create companies (SIAE) feat(Brevo): méthode pour créer des entreprises (SIAE) Feb 26, 2024
@raphodn raphodn requested a review from madjid-asa February 26, 2024 15:46
@raphodn raphodn marked this pull request as ready for review February 26, 2024 15:46
@raphodn raphodn force-pushed the raphodn/brevo-api-siae branch 2 times, most recently from 53a59b8 to 579c191 Compare February 26, 2024 15:56
@raphodn raphodn mentioned this pull request Feb 27, 2024
Merged
madjid-asa
madjid-asa approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@madjid-asa madjid-asa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, juste si tu peux changer le format des string c'est cool

lemarche/utils/apis/api_brevo.py Outdated Show resolved Hide resolved
lemarche/utils/apis/api_brevo.py Outdated Show resolved Hide resolved
Base automatically changed from raphodn/siae-extra-data-field to master February 27, 2024 16:50
@raphodn raphodn force-pushed the raphodn/brevo-api-siae branch from 780222a to 11c008a Compare February 27, 2024 17:09
@raphodn raphodn force-pushed the raphodn/brevo-api-siae branch from 11c008a to f5cbacc Compare February 27, 2024 17:13
@raphodn raphodn changed the title feat(Brevo): méthode pour créer des entreprises (SIAE) feat(Brevo): méthode pour créer (et maj) des entreprises (SIAE) Feb 27, 2024
@raphodn raphodn merged commit 1225a0c into master Feb 27, 2024
6 checks passed
@raphodn raphodn deleted the raphodn/brevo-api-siae branch February 27, 2024 17:16
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madjid-asa madjid-asa madjid-asa approved these changes

Assignees

@raphodn raphodn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphodn @madjid-asa