feat(api) Pouvoir chercher les structures par SIREN #1074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastienReuiller
approved these changes
Feb 13, 2024
| url = reverse("api:siae-retrieve-by-siren", args=["444444444"]) | ||
| response = self.client.get(url) | ||
| self.assertEqual(response.status_code, 200) | ||
| # self.assertEqual(type(response.data), list) |
There was a problem hiding this comment.
Tu as laissé des lignes commentées 😉
| @classmethod | ||
| def setUpTestData(cls): | ||
| SiaeFactory(name="Une structure", siret="12312312312345", department="38") | ||
| SiaeFactory(name="Une autre structure", siret="22222222222222", department="69") |
There was a problem hiding this comment.
J'aurai peut-être changé les 5 derniers chiffres pour avoir des SIRET différents sur le même SIREN. Je pense que c'est plus réaliste.
There was a problem hiding this comment.
je vais faire ca dans une petite PR séparée 👌
et améliorer un peu cet endpoint par siret
raphodn
changed the title
raphodn
force-pushed
the
raphodn/api-siae-by-siren
branch
from
81bfbd0 to
5a39ef8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Autre demande d'API Entreprise (après la #955)
Avoir une URL pour récupérer les structures par siren (on avait déjà par siret)
/siae/siren/<siren>