Emails : finaliser la configuration d'envoi d'-mails transactionnels avec Brevo #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
changed the title
raphodn
commented
Jan 9, 2024
lemarche/utils/apis/api_brevo.py
Outdated
|
|
||
|
|
||
| ENV_NOT_ALLOWED = ("dev", "test") | ||
| def get_default_client(): |
There was a problem hiding this comment.
je me rends compte qu'il y aura surement des conflits avec #1028
SebastienReuiller
approved these changes
Jan 16, 2024
| params=variables, | ||
| ) | ||
|
|
||
| if settings.BITOUBI_ENV not in ENV_NOT_ALLOWED: |
There was a problem hiding this comment.
C'est fait comme ça partout, mais je pense qu'on peut avoir une réflexion sur ce ENV_NOT_ALLOWED, pour peut-être le centraliser dans le settings et l'inverser pour éviter les erreurs (ENV_ALLOWED).
raphodn
force-pushed
the
raphodn/emails-brevo-configuration
branch
from
846d7c4 to
80a4509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Lié à #1028
La configuration actuelle fonctionne mais ne permettait pas d'envoyer des e-mails transactionnels à la manière de Mailjet.
J'ai aussi modifié le DEFAULT_FROM_EMAIL & DEFAULT_FROM_NAME