Hotfix: siae_user.full_name in Siae completion reminder task. ref #753

gip-inclusion · May 30, 2023 · 465d443 · 465d443
1 parent b313905
commit 465d443
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/lemarche/siaes/management/commands/send_completion_reminder_emails.py b/lemarche/siaes/management/commands/send_completion_reminder_emails.py
@@ -1,11 +1,12 @@
 import calendar
 
-from django.core.management.base import BaseCommand, CommandError
+from django.core.management.base import CommandError
 from django.utils import timezone
 
 from lemarche.siaes.models import Siae
 from lemarche.siaes.tasks import send_completion_reminder_email_to_siae
 from lemarche.utils.apis import api_slack
+from lemarche.utils.commands import BaseCommand
 
 
 class Command(BaseCommand):

diff --git a/lemarche/siaes/tasks.py b/lemarche/siaes/tasks.py
@@ -36,11 +36,11 @@ def set_siae_coords(model, siae):
 
 def send_completion_reminder_email_to_siae(siae):
     email_subject = "Vous avez raté des opportunités commerciales !"
-    siae_user_emails = siae.users.values_list("email", flat=True)
+    siae_user_emails = list(siae.users.values_list("email", flat=True))
     recipient_list = whitelist_recipient_list(siae_user_emails)
     if recipient_list:
         for siae_user_email in recipient_list:
-            siae_user = User.objects.get(email=siae_user_email).first_name
+            siae_user = User.objects.get(email=siae_user_email)
             recipient_name = siae_user.full_name
 
             variables = {