refactor: isoler les settings de test #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentporte
force-pushed
the
vp/isolate_test_conf
branch
3 times, most recently
from
990b218 to
a04191f
Compare
vincentporte
requested review from
francoisfreitag,
calummackervoy,
xavfernandez and
tonial
10 tasks
…alues from base.py
vincentporte
force-pushed
the
vp/isolate_test_conf
branch
from
a04191f to
a3fe130
Compare
….py, lighten ci vars declaration
vincentporte
force-pushed
the
vp/isolate_test_conf
branch
from
0d6775e to
c20105f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Isoler les
settingsde test, pour nettoyer les valeurs par défaut dessettingsde base et de dev.🎸 Utiliser ces
settingsde test pour rendre les tests executables dès le tirage du dépôt.🎸 Utiliser ces
settingsdans laCIpour harmoniser l'execution des tests en local et dans les actions githubType de changement
🚧 technique
Points d'attention
🦺 refactor de l'appel aux settings liés aux envois de mails
🦺 simplification de la gestion des routes
brevo🦺 harmonisation des
settingsutilisés pour envoyer le lien magique par mail ou dans lesmessagedjango🦺 prise en compte des noms de bucket issus des
settingsdans les fichiers de migration📦 prerequis à la PR #857