fix: 🦇 désactiver la suppression en masse des Post depuis l'admin django
#861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vincentporte
changed the title
Topic sans Post
vincentporte
added
the
hot fix
francoisfreitag
approved these changes
Dec 17, 2024
|
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
…make it more readable and use with_post trait
…ke it more readable and use with_post trait
…it does not update related objects (ie posts_count), making website ~crashes~ inconsistent
vincentporte
force-pushed
the
860-topic-sans-post
branch
from
2cbbd3e to
4b1e38a
Compare
vincentporte
changed the title
Topic sans PostPost depuis l'admin django
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Il est apparu un cas de
Topicoùposts_countétait supérieur à zéro après la suppression duPostassocié via l'admin.🎸 Ce
Topica fait échouer en erreur 500, l'affichage des listes deTopic, lors de la tentative d'affichage des données de détail dufirst_post🪭 Issue #860, https://inclusion.sentry.io/issues/14670791/?project=4508410606452816
🪭 Cas reproduit en supprimant des
Postdepuis la liste dans l'admin🪭 Cause identifiée : la méthode
delete_selectedn'appelle pas la méthodedeletedemachinasur ces objets. Les données dénormalisées desTopicassociés ne sont pas mises à jour.🧦 Patch : desactivation de la méthode
delete_selecteddans l'adminType de changement
🪲 Correction de bug (changement non cassant qui corrige un problème).
🚧 technique
Points d'attention
🦺 factorisation des paramètres commun des queryset
unansweredetoptimized_for_topics_list🦺 mise à jour des tests impactés et ajout du trait
with_disapproved_post, réécriture simplifiée en pytest🦺 des cas similaires peuvent se produire sur les
Topicvs les données dénormalisées desForum. Celles-ci ne sont pas exploitées dans l'UI, pas d'incidence pour le moment.