feat: POC, autoconnection les emplois vers la commu via Pro Connect #851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonial
approved these changes
Dec 5, 2024
|
|
||
| class ProConnectLoginMiddleware(MiddlewareMixin): | ||
| def process_request(self, request): | ||
| query_params = request.GET.copy() |
There was a problem hiding this comment.
Je commencerais plutot la méthode par
if "proconnect_login" not in request.GET:
return
afin d'éviter de copier le query_dict à chaque passage dans le middleware
Comment on lines
18
to
19
| assert response.url == f"/{expected}" | ||
| assert response.status_code == 302 |
There was a problem hiding this comment.
Suggested change
| assert response.url == f"/{expected}" | |
| assert response.status_code == 302 | |
| from pytest_django.asserts import assertRedirects | |
| assertRedirects(response, f"/{expected}") |
vincentporte
pushed a commit
that referenced
this pull request
Dec 16, 2024
🤖 I have created a release *beep* *boop* --- ## [2.19.0](v2.18.0...v2.19.0) (2024-12-16) ### Features * amélioration bouton pro_connect ([#847](#847)) ([09397af](09397af)) * harmonisation des liens de connexion ([#844](#844)) ([fb50472](fb50472)) * **home:** afficher les questions en attente de réponse sur la page d'accueil ([#830](#830)) ([300a7bd](300a7bd)) * mise à jour de la politique de confidentialité ([#845](#845)) ([fa5d0d4](fa5d0d4)) * **notification:** informer les abonnés des nouvelles questions dans un forum ([#835](#835)) ([432fec2](432fec2)) * POC, autoconnection les emplois vers la commu via Pro Connect ([#851](#851)) ([56e3163](56e3163)) * renommage des upvotes ([#842](#842)) ([4491d8d](4491d8d)) ### Bug Fixes * hydratation du parametre `next` dans l'url proconnect:authorize ([#850](#850)) ([3486f6e](3486f6e)) * **stats:** desactivation de la collecte des stats automatique ([#859](#859)) ([5bf3aea](5bf3aea)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoConnect les emplois <> la commu
Partie 1 : les emplois > la commu
Scope : Orienteurs et SIAE
Description
🎸 Permettre à un utilisateur authentifié dans le site des emplois via ProConnect, d'être automatiquement connecté via ProConnect dans la communauté
Type de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
Points d'attention
🦺 capture du paramètre
proconnect_logindans l'url par unmiddlewaredédié🦺 retraitement de l'url pour supprimer le paramètre
proconnect_logindans tous les cas