-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simplifier la collecte des destinataires des questions en attente #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for staff django users
…d its cronified script
…t use of ForumFactory
francoisfreitag
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ça m’a l’air correct et il est plus facile de gérer les destinataire dans l’app que dans Brevo. 👍
Je suis surpris qu’il n’y ait pas de nombre maximal de destinataires pour le mail, mais c’est un problème existant.
vincentporte
pushed a commit
that referenced
this pull request
Dec 2, 2024
🤖 I have created a release *beep* *boop* --- ## [2.18.0](v2.17.0...v2.18.0) (2024-11-28) ### Features * mise à jour de la politique de confidentialité ([#824](#824)) ([6cfed1a](6cfed1a)) * mise à jour UI des ecrans de connexion ([#825](#825)) ([8f1e4f8](8f1e4f8)) * simplifier la collecte des destinataires des questions en attente ([#833](#833)) ([22eb8ca](22eb8ca)) * **stats:** suppression de la page cachée ([#828](#828)) ([92bf7d8](92bf7d8)) ### Bug Fixes * anonymiser les urls de profil des utilisateurs ([#832](#832)) ([6f03e8f](6f03e8f)) * **log:** patch [#810](#810) ([#822](#822)) ([436c6a4](436c6a4)) * retarder la collecte des statistiques matomo ([#826](#826)) ([dfca7e8](dfca7e8)) * **stats:** ajout des liens vers les forums dans la page de statistique des fiches pratiques ([#827](#827)) ([63e2220](63e2220)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Simplifier la génération de la liste des contacts destinataires de la notification quotidienne sur le nombre de questions en attente
users staff
Type de changement
🥁 Changement de rupture (modification ou caractéristique qui empêcherait une fonctionnalité existante de fonctionner comme prévu) nécéssitant une mise à jour de la documentation
Points d'attention
🦺 refactor du test
SendNotifsOnUnansweredTopics
en pytest style