Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(forum): gabarit séparé pour les forums de documentation #680

Merged
merged 23 commits into from
Jul 3, 2024

Conversation

calummackervoy
Copy link
Contributor

Description

🎸 Séparation des gabarits servis selon la type de forum, en partageant le même parent

Type de changement

🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).

@calummackervoy calummackervoy marked this pull request as ready for review June 17, 2024 11:04
@calummackervoy calummackervoy force-pushed the 663-forum-template-refactor branch from 0d907f3 to 1f1e551 Compare June 18, 2024 12:37
Copy link
Contributor

@vincentporte vincentporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prévois tu d'ajouter des tests de rendus avec snapshot ?

lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/views.py Outdated Show resolved Hide resolved
@calummackervoy calummackervoy force-pushed the 663-forum-template-refactor branch from 20311ba to 723fcdd Compare June 19, 2024 12:16
Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je laisse Vincent vérifier les pages, j’ai juste jeté un œil aux tests.
La fixture est très bien. On pourrait imaginer changer la signature pour :

-def reset_model_sequence_fixture(model_class):
+def reset_model_sequence_fixture(*model_classes):

Il est probable qu’on souhaite reset plusieurs séquences. 🤷

lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/utils/testing.py Outdated Show resolved Hide resolved
lacommunaute/utils/testing.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vincentporte vincentporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tu testes comment jamais la commu n'a été testée ;) Congrats !

lacommunaute/forum/views.py Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
lacommunaute/forum/tests/tests_views.py Outdated Show resolved Hide resolved
@vincentporte
Copy link
Contributor

on a un petit souci sur le rendu des fiches pratiques

actuel
image

dans la branche en cours
image

et dans le rendu des thématiques

actuel
image

dans la branche en cours
image

A force de nous concentrer sur des details de techs, nous avons failli passer à coté du fonctionnel métier 8-)

@calummackervoy
Copy link
Contributor Author

@vincentporte t'as une fixture Django avec les thématiques problèmatiques que t'as montré dans l'image que je peux piquer s'il te plaît ? J'ai du mal à réproduire localement :

Screenshot 2024-07-01 at 17 21 19 Screenshot 2024-07-01 at 17 22 19

J'avais bien pensé à tester dans le navigateur et pas juste sur snapshot ! 😄

@calummackervoy
Copy link
Contributor Author

@vincentporte j'ai ajouté quelques autres tests snapshots pour le contenu des autres gabarits (forum_detail.html et forum_documentation_category.html), et j'ai répondu aux autres retours. Hors de le soucis avec les différentes comportements en locale tout est prêt normalement

@calummackervoy calummackervoy force-pushed the 663-forum-template-refactor branch from 5522a03 to dd3a862 Compare July 2, 2024 20:57
Copy link
Contributor

@vincentporte vincentporte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 LGTM

@calummackervoy calummackervoy force-pushed the 663-forum-template-refactor branch from dd3a862 to 38692e4 Compare July 3, 2024 14:57
@calummackervoy calummackervoy merged commit fedd5ca into master Jul 3, 2024
8 checks passed
@calummackervoy calummackervoy deleted the 663-forum-template-refactor branch July 3, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FORUM] utiliser des templates différents selon les types de forum
3 participants