-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(documentation): ajouter des vidéos YT dans les fiches pratiques #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
vincentporte
force-pushed
the
vincentporte/yt_firsttry
branch
from
April 16, 2024 12:46
06a9c9f
to
f8bfd68
Compare
vincentporte
changed the title
yt 1st try
[DOCUMENTATION] ajouter des vidéos YT dans les fiches pratiques
Apr 16, 2024
vincentporte
commented
Apr 16, 2024
vincentporte
commented
Apr 16, 2024
vincentporte
commented
Apr 16, 2024
vincentporte
force-pushed
the
vincentporte/yt_firsttry
branch
from
April 16, 2024 13:05
f8bfd68
to
d99d1f7
Compare
🥁 La recette jetable est prête ! 👉 Je veux tester cette PR ! |
Closed
hellodeloo
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vincentporte
force-pushed
the
vincentporte/yt_firsttry
branch
from
April 16, 2024 13:49
d99d1f7
to
f6d73a1
Compare
…rendering post content
…s are checked when saving instance. They still are forbidden. Ability to accept html is for YT iframe embed in forum description
vincentporte
force-pushed
the
vincentporte/yt_firsttry
branch
2 times, most recently
from
April 17, 2024 13:01
b3abfc9
to
c69d84b
Compare
vincentporte
force-pushed
the
vincentporte/yt_firsttry
branch
from
April 17, 2024 13:04
c69d84b
to
158ac51
Compare
vincentporte
changed the title
[DOCUMENTATION] ajouter des vidéos YT dans les fiches pratiques
feat(documentation): ajouter des vidéos YT dans les fiches pratiques
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
🎸 Permettre l'ajout de vidéos YT dans les fiches pratiques
Type de changement
🎢 Nouvelle fonctionnalité (changement non cassant qui ajoute une fonctionnalité).
🚧 technique
Points d'attention
🦺 Désactiver les CSP en mode débug, pour tester en local
⚠️ ⚠️ encapsulation de chaque iframe dans une balise
🦺 Autoriser le rendu de code html lors de la sauvegarde d'une instance de type
Forum
:safe_mode=False
dansMACHINA_MARKUP_LANGAGE
🦺 Les codes html restent interdits dans les messages (
Post
) des utilisateurs : ajout desafe_mode=True
dans la fonction de rendering de la méthodecheck_post_approbation
🦺 Ajout d'une
div
avec la classetextarea_cms_md
pour gérer le dimensionnement de l'iframediv
pour ne pas casser le rendu de la page. L'ajout est fait lors du rendu deforum.description.rendered
pendant l'enregistrement deForum
. En cas d'édition, les balisesdiv
seront vraisemblablement présentes : pas d'ajout supplémentaire ;)Captures d'écran (optionnel)