Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONVERSATION] masquer le bouton "voir les 999 reponses" (fix) #417

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

vincentporte
Copy link
Contributor

Description

🎸 nettoyage des scripts :

  1. suppression du code mort : onclick=DisabledMe en prévision de l'application des Content Security Policies
  2. insertion unique du script d'ajout de la classe d-none au bouton en objet au niveau du template topic_list.html au lieu de posts_list.html pour éviter la duplication du code dans la page rendu ET une erreur dans la vue de détail d'un topic

Type de changement

🚧 technique

@vincentporte vincentporte added the hot fix Pull requests that fix a bug to fix as soon as possible label Sep 21, 2023
@vincentporte vincentporte self-assigned this Sep 21, 2023
@vincentporte vincentporte changed the title [CONVERSATION] correction du masquage du bouton "voir les 999 reponses" [CONVERSATION] masquer le bouton "voir les 999 reponses" (fix) Sep 21, 2023
@vincentporte vincentporte merged commit d702c43 into master Sep 21, 2023
4 checks passed
@vincentporte vincentporte deleted the vincentporte/redundant_script_call branch September 21, 2023 09:39
@vincentporte vincentporte mentioned this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hot fix Pull requests that fix a bug to fix as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant