chore(soliguide): remove bad se-presenter #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When address is missing.
vmttn
commented
Sep 26, 2024
| ) AS m | ||
| ARRAY_REMOVE( | ||
| ARRAY[ | ||
| CASE WHEN (open_services.modalities__inconditionnel OR open_services.modalities__inscription__checked) AND lieux.position__address IS NOT NULL THEN 'se-presenter' END, |
There was a problem hiding this comment.
l'endroit pertinent est ici, le reste c'est du refacto pour permettre de traiter le cas proprement
vmttn
commented
Sep 26, 2024
| position__coordinates__y AS "latitude", | ||
| position__additional_information AS "complement_adresse", | ||
| position__city AS "commune", | ||
| lieu_id AS "id", |
There was a problem hiding this comment.
juste du reformattage
vmttn
commented
Sep 26, 2024
| NULL | ||
| ) | ||
| ) AS m | ||
| ARRAY_REMOVE( |
There was a problem hiding this comment.
juste pour simplifier et harmoniser avec ci-dessous
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
se-presenterne devrait pas être défini lorsque l'adresse n'est pas disponible