Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(api) : Fix load_inclusion_data import #304

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

vperron
Copy link
Contributor

@vperron vperron commented Sep 25, 2024

There is a race condition where the import was started at exactly 30 minutes after every hour, which unfortunately is about exactly the moment when the now hourly main DAG exports its parquet files :x

    [2024-09-25, 08:33:42 UTC] {process_utils.py:194} INFO - uploading data to bucket='data/marts/2024-09-25/scheduled__2024-09-25T07:00:00+00:00/services.parquet'
    [2024-09-25, 08:33:49 UTC] {python.py:240} INFO - Done. Returned value was: None

Reset it at the first minute of the hour to maximize our chances.

Also, stop doing a difference for staging, as the data there isn't smaller.

There is a race condition where the import was started at exactly 30
minutes after every hour, which unfortunately is about exactly the
moment when the now hourly `main` DAG exports its parquet files :x

    [2024-09-25, 08:33:42 UTC] {process_utils.py:194} INFO - uploading data to bucket='data/marts/2024-09-25/scheduled__2024-09-25T07:00:00+00:00/services.parquet'
    [2024-09-25, 08:33:49 UTC] {python.py:240} INFO - Done. Returned value was: None

Reset it at the first minute of the hour to maximize our chances.

Also, stop doing a difference for staging, as the data there isn't
smaller.
@vperron vperron merged commit 8eb92ea into main Sep 25, 2024
6 of 8 checks passed
@vperron vperron deleted the vperron/fix-api-import branch September 25, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants