feat(pipeline) : Send RGPD notifications to mes-aides & mediation-numerique #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has since been fixed.
They will also be part of the notification campaign about displaying their e-mail address in the API.
Make it dead simple for now. - the notifications were not sent, even though the mailing list attached seemed OK in the interface - we update the list in the same DAG as the notification dispatch - we suppose that the list is not "properly updated" server-side at the time we send the notifications (race condition) so we introduce a fixed wait time for now. We checked that re-triggering the notification alone (without the ML sync) was indeed working, so chances are on our side. If the MLs are dispatched next month properly, we could work on a mechanism that actually checks the ML contents but... not sure we should bother. BTW TimeDeltaSensor was interesting but unfortunately does not work super well as the delta is computed from the start date of the DAG which is "somewhere in 2023", so it does not wait at all in its current form (without changing much of the DAG shape and initial params), so we took a quick and simple (dirty ?) approach.
vperron
force-pushed
the
vperron/more-brevo-contacts
branch
from
2936c17 to
4b13aa4
Compare
vmttn
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
lgtm
j'ai l'impression qu'on aurait plus de faciliter à tester cette feature si on utilisait plpython pour modéliser les traitements. On pourrait imaginer des unit_test avec une dummy implementation de brevo et des tests d'intégration avec brevo purement en python (deja faisable en fait). Ou un faux environnement brevo pour tester (ce qui me semble moins évident à maintenir). En tout cas ça pourrait simplifier l'orchestration
|
J'ai tellement hâte de passer plein de trucs en plpython :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vérifié localement que les doublons de la médiation numérique avec Dora, quand l'adresse est la même, ne sont pas notifiés à nouveau (le système fonctionne comme prévu, quoi)