Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pipeline): map fredo #257

Merged
merged 7 commits into from
Aug 28, 2024
Merged

feat(pipeline): map fredo #257

merged 7 commits into from
Aug 28, 2024

Conversation

hlecuyer
Copy link
Contributor

No description provided.

@vmttn vmttn changed the title wip feat(pipeline): map fredo Jul 12, 2024
vmttn
vmttn reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@vmttn vmttn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool ! Quelques commentaires plutot sur le code, je n'ai pas encore checké plus en détail

pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/staging/sources/fredo/_fredo__models.yml Show resolved Hide resolved
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch 2 times, most recently from 4835639 to 53d95b0 Compare July 15, 2024 15:25
vmttn
vmttn requested changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@vmttn vmttn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

encore quelques petits détails, mais c'est propre 👍

pipeline/dbt/models/intermediate/sources/fredo/_map_fredo_thematiques.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__structures.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__services.sql Outdated Show resolved Hide resolved
pipeline/dbt/models/intermediate/sources/fredo/int_fredo__structures.sql Outdated Show resolved Hide resolved
pipeline/pyproject.toml Outdated Show resolved Hide resolved
pipeline/scripts/update_schema_seeds.py Outdated Show resolved Hide resolved
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch from bca26d5 to 78947e5 Compare July 17, 2024 15:30
@hlecuyer hlecuyer requested a review from vmttn July 18, 2024 07:29
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch 2 times, most recently from 191840b to cc5e677 Compare July 18, 2024 12:46
vmttn
vmttn reviewed Jul 18, 2024
View reviewed changes
Copy link
Contributor

@vmttn vmttn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

à part les dates de màj, lgtm ! on passe en ready for review et on regarde ce que ça donne en staging et sur la preprod dora ?

@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch from cc5e677 to c9e4d65 Compare July 18, 2024 14:03
@hlecuyer hlecuyer marked this pull request as ready for review July 18, 2024 14:06
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch 4 times, most recently from c716788 to 37f5d95 Compare July 18, 2024 15:25
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch from e6ede5b to ff573bf Compare July 18, 2024 15:47
@vmttn vmttn self-requested a review July 24, 2024 07:07
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch from dc52901 to acdac32 Compare July 30, 2024 13:47
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch from e23e0a1 to bf25007 Compare August 1, 2024 14:08
@hlecuyer hlecuyer force-pushed the feat/pipeline/integration-fredo2 branch from bf25007 to 0a7858d Compare August 27, 2024 07:19
@hlecuyer hlecuyer merged commit 9f1a37c into main Aug 28, 2024
7 of 8 checks passed
@hlecuyer hlecuyer deleted the feat/pipeline/integration-fredo2 branch August 28, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmttn vmttn Awaiting requested review from vmttn vmttn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hlecuyer @vmttn