Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pipeline): replace char special by oe #255

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

hlecuyer
Copy link
Contributor

@hlecuyer hlecuyer commented Jul 3, 2024

No description provided.

@vmttn
Copy link
Contributor

vmttn commented Jul 8, 2024

est-ce que tu pourrais déplacer ça ici ?

def unaccent(text: str) -> str:

@@ -23,8 +23,12 @@
def unaccent(text: str) -> str:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je te propose de :

  1. renommer la fonction en normalize
  2. séparer la fonction en 2 parties distinctes :
    a. retirer les accents
    b. remplacer la ligature

@vmttn vmttn merged commit 5a6a661 into main Jul 9, 2024
8 of 9 checks passed
@vmttn vmttn deleted the feat/pipeline/fix-char-mon-enfant branch July 9, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants