Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pipeline): run snapshot after all extracts #246

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

vmttn
Copy link
Contributor

@vmttn vmttn commented May 29, 2024

The snapshot task is not connected to all extract task groups.

The snapshot task is not connected to all extract task groups.
Copy link
Contributor

@vperron vperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh mon dieu :/ Belle trouvaille.

PI on pourrait mettre un test de non régression en qques lignes dans tests/ci/test_dags.py qui ferait:

dags = DagBag()

IMPORT_DAGS = [dag_id for dag_id in dags.dag_ids if dag_id.startswith("import_")]

@pytest.mark.parametrize("dag_id", IMPORT _DAGS)
def test_dag_import_sources(dag_id):
    dag = dags.get_dag(dag_id=dag_id)
    assert dag.task_dict.keys() == ["start", ..., "end"]

Quelque chose dans c egenre là ?

@vmttn vmttn merged commit 10c5529 into main Jun 3, 2024
6 checks passed
@vmttn vmttn deleted the vmttn/fix/branch-snapshot-to-all-extract-groups branch June 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants