-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(pipeline): update xp data #178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pas de grandes remarques ! Merci pour toutes les infos dans le message de PR.
@@ -438,6 +440,7 @@ def search_services( | |||
query = query.filter(models.Structure.source != "agefiph") | |||
if not request.user.is_authenticated or "dora" not in request.user.username: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
j'espère que le username
"adorable" n'existe pas ^^
@@ -438,6 +440,7 @@ def search_services( | |||
query = query.filter(models.Structure.source != "agefiph") | |||
if not request.user.is_authenticated or "dora" not in request.user.username: | |||
query = query.filter(models.Structure.source != "soliguide") | |||
query = query.filter(models.Structure.source != "data-inclusion") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit sans intéret ici : de ce que je comprends les données soliguide et data-inclusion sont donc dispo si je ne suis pas authentifié ? Ou je loupe quelque chose ?
The xp data was previously extracted from dora in staging. This hack has saved us some time, but it's time to stop. First, the data could be wipped by the team at dora. Second, it's difficult to update. Following the migration of the xp data from dora staging to a clean google sheet, this commit updates transformation accordingly.
45e3745
to
491cd7a
Compare
Contexte :
data/raw/2022-01-01/data-inclusion/*
)3 problèmes :
@example.com
) et je pense que c'est simplement liée à la preproddata-inclusion
, ce qui est on ne peut plus ambiguëChangements :
Reste à faire :