Gio/test ats update #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly these changes alter the codecov_ats workflow to generate 2 outputs: * ATS_TESTS_TO_RUN - list of tests (and options to pytest) that codecov thinks you should run * ATS_TESTS_TO_SKIP - list of tests (and options to pytest) that codecov thinks you should skip There are some config changes to `codecov.yml`: * The yaml validator was accusing coverage.status.project and coverage.status.patch to be invalid because of the "default" key. * Adding a "smart-tests" flag that would be used with ATS (if the tests are run) Another notable change is the `fetch-depth` when checking out the code from 0 to 2. I changed the BASE_COMMIT to be the parent commit, so 2 should suffice.
From https://github.com/orgs/community/discussions/46992#discussioncomment-4961541 This should allow us to populate the appropriate env vars even if the label-analysis step fails. Which is not the case currently (see https://github.com/giovanni-guidini/sentry/actions/runs/6409333248/job/17400305852)
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
===========================================
- Coverage 83.62% 83.34% -0.29%
===========================================
Files 2605 4379 +1774
Lines 153895 320952 +167057
Branches 26798 35537 +8739
===========================================
+ Hits 128702 267509 +138807
- Misses 19953 47605 +27652
- Partials 5240 5838 +598
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing that the correct BASE is picked