Skip to content

Commit

Permalink
Override fail-fast of GHA shell
Browse files Browse the repository at this point in the history
From https://github.com/orgs/community/discussions/46992#discussioncomment-4961541

This should allow us to populate the appropriate env vars even if the label-analysis step fails.
Which is not the case currently (see https://github.com/giovanni-guidini/sentry/actions/runs/6409333248/job/17400305852)
  • Loading branch information
giovanni-guidini committed Oct 5, 2023
1 parent fe8cde9 commit def54cc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/codecov_ats.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
token: ${{ github.token }}
filters: .github/file-filters.yml
coverage-ats:
#if: needs.files-changed.outputs.backend == 'true'
if: needs.files-changed.outputs.backend == 'true'
needs: files-changed
runs-on: ubuntu-latest
# Map a step output to a job output
Expand Down Expand Up @@ -89,6 +89,7 @@ jobs:
id: label_analysis
continue-on-error: true
run: |
set +e
BASE_COMMIT=$(git rev-parse ${{ github.sha }}^)
echo $BASE_COMMIT
output=$(codecovcli --codecov-yml-path=codecov.yml label-analysis --dry-run --token=${CODECOV_STATIC_TOKEN} --base-sha=${BASE_COMMIT})
Expand Down

0 comments on commit def54cc

Please sign in to comment.