Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse symbole and type #19

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

googol42
Copy link

The main change here is that when type and sym tags in gpx files are considered. They are used to determine the type of course points. The logic is: if there is a type parse it. If that fails sym is used. If parsing fails again use the GENERIC type.

Also some clean ups are done

Comment on lines -12 to -14
* create directory app/libs
* copy fit.jar from the [Garmin FitSDK](https://developer.garmin.com/fit/download/) to app/libs
* Download the [Connect IQ Mobile SDK (Android BLE/ADB)](https://developer.garmin.com/connect-iq/sdk/) and copy the .aar file to app/libs
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the dependencies so one does not have to download oneself.

I don't know if you need the files locally for some other kind of debugging. If so I can leave the documentation unchanged.

Comment on lines -349 to +369
* see Minetti, A. E. et al. (2002). Energy cost of walking and running at extreme uphill and downhill slopes.
* Journal of Applied Physiology 93, 1039-1046, http://jap.physiology.org/content/93/3/1039.full
* see <a href="http://jap.physiology.org/content/93/3/1039.full">Minetti, A. E. et al. (2002).
* Energy cost of walking and running at extreme uphill and downhill slopes.
* Journal of Applied Physiology 93, 1039-1046</a>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes a warning

Comment on lines -542 to +562
} catch (NoSuchMethodException e) {
;
} catch (IllegalAccessException e) {
;
} catch (InstantiationException e) {
;
} catch (InvocationTargetException e) {
;
} catch (NoSuchMethodException | IllegalAccessException | InstantiationException |
InvocationTargetException ignored) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removes a warning

cp.setType(CoursePoint.GENERIC);
encode.write(cp);
}
writeWayPoints(encode, wayPoints);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reduced code duplication

Comment on lines -20 to +28
private double lat = Double.NaN;
private double lon = Double.NaN;
private double ele = Double.NaN;
private Date time = null;
private double lat;
private double lon;
private double ele;
private Date time;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

values are overridden in constructor so they don't have to be set here

@googol42
Copy link
Author

@haraldh at first it seemed to work, but now I am getting Already Downloaded on my watch. Is this due to my change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant