no_std addr2line #100
Closed
no_std addr2line #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipc
requested changes
Aug 1, 2018
Cargo.toml
Outdated
| default = ["rustc-demangle", "cpp_demangle"] | ||
| default = ["std", "rustc-demangle", "cpp_demangle"] | ||
| std = ["gimli/std", "object/std", "cpp_demangle/std"] | ||
| nightly = ["gimli/alloc", "fallible-iterator/alloc"] |
| use std::rc::Rc; | ||
| use alloc::rc::Rc; | ||
| use alloc::vec::Vec; | ||
| use alloc::string::{ToString, String}; |
There was a problem hiding this comment.
Group the alloc imports together.
|
Ugh, sorry, I tested on an old nightly from before the alloc changes (I'm stuck on an old nightly for the time being). |
|
Right so it requires an object release (for the goblin bump), and a stable_deref_trait release. |
|
stable_deref_trait got a release. We're only missing an object release now. |
|
It needs a gimli release too. Also this still doesn't build. It might be simpler if I reopen #98 (which doesn't need any changes other than a rebase). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98