Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several improvements to solve DeleteCourse Test Flakiness fix #5 #51

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

augustocristian
Copy link
Contributor

@augustocristian augustocristian commented Dec 3, 2023

I have revised the "DeleteCourse" test case by incorporating the support methods stored in NavigationUtilities. This modification enhances the test's readability, and now, we only need to maintain a single code block to achieve the same functionality. In the previous version, there were multiple code duplications to execute identical operations found in other test cases.

Related to #49

@augustocristian augustocristian marked this pull request as draft December 3, 2023 22:09
…ds from NavigationUtilities

- Cleaned Navigation Utilities
- Simplified some methods
- Extracted common code, reduced code duplications
@augustocristian augustocristian force-pushed the ft_solveDeleteCourseFlakiness branch from 9c6c305 to 9dc3827 Compare December 3, 2023 22:22
Copy link
Contributor

@javiertuya javiertuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems too long to solve a single flaky test, but ok if the issue is solved.

@javiertuya javiertuya marked this pull request as ready for review December 4, 2023 11:21
@javiertuya javiertuya merged commit 8e04869 into main Dec 4, 2023
2 checks passed
@javiertuya javiertuya deleted the ft_solveDeleteCourseFlakiness branch December 4, 2023 11:21
@javiertuya javiertuya changed the title Several improvements to solve DeleteCourse Test Flakiness fix #5 #49 Several improvements to solve DeleteCourse Test Flakiness fix #5 Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants