-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create readme author list ordered as in dataset view page #2123
Draft
kencho51
wants to merge
22
commits into
gigascience:develop
Choose a base branch
from
kencho51:create-ordered-author-list
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Create readme author list ordered as in dataset view page #2123
kencho51
wants to merge
22
commits into
gigascience:develop
from
kencho51:create-ordered-author-list
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
only1chunts
reviewed
Dec 13, 2024
|
||
[Citation] | ||
Oleksyk TK; Guiblet W; Pombert JF; Valentin R; Martinez-Cruzado JC (2012): Genomic data of the Puerto Rican Parrot (<em>Amazona vittata</em>) from a locally funded project. | ||
GigaScience Database. https://dx.doi.org/10.5524/100039 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whilst you're working on the readme, can you remove this spureous carriage return, the "GigaScience Database" line should continue on the end of the title in the line above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #2116
This is a pull request for the following functionalities:
$author_sql
in functiongetReleaseDetails()
inprotected/components/StoredDatasetMainSection.php
togigadb-website/gigadb/app/models/Author.php
aslistByDatasetId()
getReleaseDetails()
getReleaseDetails()
would out the author list as it wasHow to test?
Describe how the new functionalities can be tested by PR reviewers
Follow the steps in
gigadb/app/tools/readme-generator/README.md
to spin up gigadb-website and the readme-generator services.In dev
In staging
docs/SETUP_PROVISIONING.md
to spin up staging environmentsgigadb/app/tools/readme-generator/README.md
sectionUsing readme generator tool on Bastion server
to execute the readme generator tool, or briefly as follow:How have functionalities been implemented?
Describe how the new functionalities have been implemented by the
changed code at a high level
There is inconsistency found in the author's order between readme-generator and the dataset view page, because they are using two different methods to generate the author list from the database.
readme-generator
uses the yii default methods to query database which does not concern any relationship with other tables, while dataset view uses the custom sql command to query the database with relationships with other tables are considered, and the relationship seems important as designed by the curators.In order to remove the inconsistency, the custom sql command is abstracted and is available to both
readme-generator
and the main codebase, as a result, both of them will be using the same methods to generate the authors list.Any issues with implementation?
None.
Any changes to automated tests?
Describe any automated tests that have been developed for the new
functionalities
Any changes to documentation?
Replaced
centos
withec2-user
ingigadb/app/tools/readme-generator/README.md
.Any technical debt repayment?
None.
Any improvements to CI/CD pipeline?
Describe any improvements to the Gitlab pipeline