-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use tmp folder to store temp uploaded logos in project admin form #2092
Draft
luistoptal
wants to merge
43
commits into
gigascience:develop
Choose a base branch
from
luistoptal:new-feature/376-upload-project-logos-tmp-folder
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Use tmp folder to store temp uploaded logos in project admin form #2092
luistoptal
wants to merge
43
commits into
gigascience:develop
from
luistoptal:new-feature/376-upload-project-logos-tmp-folder
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue: #376
IMPORTANT: this PR depends on this other PR: #2070 , which should be merged first
This is a pull request for the following functionalities:
The logo upload process involves:
This PR simplifies the process by saving the logo in the /tmp folder of the server machine and is suppposed to rely in whatever auto clean up config is setup in the server. The rest of the steps are unchanged
How to test?
You will need to re-run
./up.sh
and follow the instructions in #2070 to setup the storage to work local dev. Then, if you follow the same instructions to test in the mentioned PR, nothing should change from a frontend perspective.Also, the playwright tests should pass when you run:
cd playwright npm install npm run test:single admin-project-logo-upload.spec.js
How have functionalities been implemented?
- /tmp:/var/www/datasetfiles
was added. The same volume exists in the web (frontend) container and this is necessary because the frontend needs to be able to access and display the temp logosAny issues with implementation?
Any changes to automated tests?