Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort dataset files by size #2080

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

luistoptal
Copy link
Collaborator

Pull request for issue: #2067

How to test?

How have functionalities been implemented?

customized the sorting function for the size column

Any issues with implementation?

--

Any changes to automated tests?

--

@rija
Copy link
Contributor

rija commented Nov 25, 2024

Hi @luistoptal,
anything preventing you to make this PR ready, I think it's embarassing issues that bothers curators a lot.

@luistoptal
Copy link
Collaborator Author

Hi @rija

Nothing is preventing, there are about 18 pending PRs, I keep ready for review only a few at a time and set for review more of them as the existing ones are merged

I will rebase this one and make ready

@luistoptal luistoptal marked this pull request as ready for review November 25, 2024 10:42
Copy link
Contributor

@kencho51 kencho51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @luistoptal,

praise: The sorting based on size is working on my dev
issue: There should be acceptance for it
suggestion: Maybe the acceptance test could be as the followings:

Scenario: Files tab can be sort by size in ascending order
    Given I have not signed in
    And I am on "/dataset/100035"
    And I follow "Files"
    And I follow "1"
    And I should see ""
    When I click "Size"
    Then I should see ""

  Scenario: Files tab can be sort by size in descending order
    Given I have not signed in
    And I am on "/dataset/100035"
    And I follow "Files"
    And I follow "1"
    And I should see ""
    When I click "Size"
    And I click "size"
    Then I should see ""

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants