Replace RoundTripper in favour of custom NewRequest method #477
+45
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoundTripper should not modify the request as its values might be read concurrently.
|
I don't specifically think we need this though as this was documented more than 10 years ago and is not causing us any issues. |
The documentation is still valid and the change is fairly recent, this could cause problems. |
|
In the context of thousands of goroutines I would agree, but in an operator that reconciles things in order, i'm not sure but as you wish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting rid of the RoundTripper as it should not modify the request because its values might be read concurrently, see https://pkg.go.dev/net/http#RoundTripper
Proposing an alternative solution which uses
NewRequestmethod to build the request and set theX-Scope-OrgID: tenantIdheader if needed.