Fix GetLatestRelease #1330
Fix GetLatestRelease #1330
Conversation
| } | ||
| if clusterAppPreReleaseString { | ||
| return preReleaseBuildFunc(), nil | ||
| if b.clusterApp != nil { |
There was a problem hiding this comment.
This is unrelated fix, as the nil pointer panic got uncovered here as I updated the unit tests.
| @@ -36,7 +36,7 @@ var _ = Describe("Builder", func() { | |||
| // set a cluster app override where the pre-release is different | |||
| const preReleasePrefix = "test" | |||
| releasesBuilder = releasesBuilder. | |||
| WithClusterApp("0.76.1-efdaba18e6e9866d62f3214f3d898b21c21e8b48", ""). | |||
| WithClusterApp("1.0.0-efdaba18e6e9866d62f3214f3d898b21c21e8b48", ""). | |||
There was a problem hiding this comment.
Updating the test here and in other places below, as now in unit tests the latest release is v25.0.0 (and it used to be v25.1.0-demo.0), so cluster-aws version is different in the base release.
|
I have updated the unit tests and unit tests work as expected now. Also I have tested this in a small go program to try to get really published latest releases for CAPA and CAPZ from the releases repo - and it works, now it is correctly returning v28.0.0 for CAPA and v25.0.0 for CAPZ. Will merge and release this with a ping here, for the sake of fixing e2e tests as soon as possible tomorrow (when I am AFK, hence fixing this now). |
This PR fixes the
GetLatestReleasein the Releases SDK to correctly return the latest release according to semver, and not the latest published GitHub release. The function now searches for the latest release in the releases GitHub repo and not in GitHub releases.After merging and releasing this, we should then bump the Releases SDK version that we use in e2e tests, in order to fix the currently broken CAPA tests.