Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix api-spec app name #983

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Fix api-spec app name #983

merged 2 commits into from
Dec 12, 2023

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR ...

Checklist

@QuentinBisson QuentinBisson self-assigned this Dec 5, 2023
@QuentinBisson QuentinBisson requested a review from a team as a code owner December 5, 2023 10:41
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean we'll have a new set of failing apps when this is released?

@QuentinBisson
Copy link
Contributor Author

Nope we are just ignoring this one because ownership is unclear :D

@QuentinBisson QuentinBisson enabled auto-merge (squash) December 12, 2023 12:33
@QuentinBisson QuentinBisson merged commit a7b4365 into master Dec 12, 2023
5 checks passed
@QuentinBisson QuentinBisson deleted the Allow-app-suffix-in-app-name branch December 12, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants