Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add team in SLO alert #971

Merged
merged 1 commit into from
Nov 27, 2023
Merged

add team in SLO alert #971

merged 1 commit into from
Nov 27, 2023

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/giantswarm/issues/28751

This PR relabel the team label so alerts can be grouped by the team label in alertmanager configuration

Checklist

@QuentinBisson QuentinBisson self-assigned this Nov 22, 2023
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson force-pushed the relabel-team-in-slo-alert branch from 294598f to 555fd73 Compare November 23, 2023 11:06
@QuentinBisson QuentinBisson marked this pull request as ready for review November 23, 2023 14:25
@QuentinBisson QuentinBisson requested a review from a team as a code owner November 23, 2023 14:25
@QuentinBisson
Copy link
Contributor Author

Tested on gauss, waiting for review :)

@QuentinBisson QuentinBisson merged commit 13553dc into master Nov 27, 2023
5 checks passed
@QuentinBisson QuentinBisson deleted the relabel-team-in-slo-alert branch November 27, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants