Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keda alerting rules #942

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Add keda alerting rules #942

merged 2 commits into from
Nov 7, 2023

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Nov 6, 2023

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/adidas/issues/1213

This PR adds keda alerting rules. They are configurés to only notify for now

Checklist

@QuentinBisson QuentinBisson requested review from a team November 6, 2023 14:24
@QuentinBisson QuentinBisson self-assigned this Nov 6, 2023
@QuentinBisson QuentinBisson marked this pull request as ready for review November 6, 2023 14:25
@QuentinBisson QuentinBisson requested a review from a team as a code owner November 6, 2023 14:25
Signed-off-by: QuentinBisson <[email protected]>
@T-Kukawka
Copy link
Contributor

This should wait for the same reason KSM is waiting, to figure out the whole oncall setup that is currently not working

@QuentinBisson
Copy link
Contributor Author

Moved ownership to atlas for now until turtles has more time

@hervenicol
Copy link
Contributor

This PR adds keda alerting rules (only KEDA down is a paging alert)

Looks like it is not, as I see it as severity: notify.

Out of curiosity, did you come up with these alerts, or are these alerts suggested upstream? Maybe the link to upstream should be provided as a comment if that's the case.

@QuentinBisson
Copy link
Contributor Author

So this alert was paging until Yesterday evening 😂
I came up with those myself. They don't provide much upstream apart from exposés metrics

@QuentinBisson QuentinBisson merged commit 9cf0d30 into master Nov 7, 2023
4 checks passed
@QuentinBisson QuentinBisson deleted the add-keda-alerts branch November 7, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants