Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster-info recording rule #931

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/giantswarm/issues/28268

This PR adds a recording rule to be able to list all clusters to be used in join with absent functions

Checklist

@QuentinBisson QuentinBisson self-assigned this Oct 12, 2023
@QuentinBisson QuentinBisson marked this pull request as ready for review October 12, 2023 12:04
@QuentinBisson QuentinBisson requested a review from a team as a code owner October 12, 2023 12:04
- expr: |-
avg by (cluster_id, customer, installation) (
label_replace(
capi_cluster_info,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAPI clusters

"name",
"(.*)"
)
or cluster_operator_cluster_status
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vintage WCs

or cluster_operator_cluster_status
or cluster_service_cluster_info
or
label_replace(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Management clusters

@QuentinBisson QuentinBisson force-pushed the add-cluster-info-recording-rule branch from 1470252 to 763f439 Compare October 12, 2023 12:05
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson force-pushed the add-cluster-info-recording-rule branch from 763f439 to 6330dee Compare October 12, 2023 12:23
@QuentinBisson
Copy link
Contributor Author

Gauss:
image

@QuentinBisson
Copy link
Contributor Author

Golem:
image

Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice !

@QuentinBisson QuentinBisson merged commit d152844 into master Oct 16, 2023
5 checks passed
@QuentinBisson QuentinBisson deleted the add-cluster-info-recording-rule branch October 16, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants