Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

increase time to trigger promtailrequestserrors alert #1453

Merged
merged 2 commits into from
Dec 9, 2024
Merged

increase time to trigger promtailrequestserrors alert #1453

merged 2 commits into from
Dec 9, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

Towards: https://github.com/giantswarm/giantswarm/issues/32214

This PR increases the time threshold for the PromtailRequestsErrors alert which is currently too sensitive.

Checklist

@QuantumEnigmaa QuantumEnigmaa self-assigned this Dec 9, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner December 9, 2024 11:16
@QuantumEnigmaa
Copy link
Contributor Author

@hervenicol all good for your ?

hervenicol
hervenicol approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuantumEnigmaa QuantumEnigmaa merged commit 913f4c2 into main Dec 9, 2024
7 checks passed
@QuantumEnigmaa QuantumEnigmaa deleted the lower-promtailrequestserrors-sensitivity branch December 9, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hervenicol hervenicol hervenicol approved these changes

@QuentinBisson QuentinBisson QuentinBisson approved these changes

Assignees

@QuantumEnigmaa QuantumEnigmaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@QuantumEnigmaa @QuentinBisson @hervenicol