Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app.rules.yml #1418

Merged
merged 3 commits into from
Nov 7, 2024
Merged

Update app.rules.yml #1418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0b80512
Update app.rules.yml
ljakimczuk Nov 6, 2024
97d598b
Fix tests?
ljakimczuk Nov 6, 2024
f9e9b61
Changelog
ljakimczuk Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Fixes the statefulset.rules name as it is currently replacing the deployment.rules alerts.
- Extends AppCR-related alerts with cancelation for CAPI clusters with unavailable control plane.

## [4.22.0] - 2024-10-29

Expand Down
3 changes: 3 additions & 0 deletions helm/prometheus-rules/templates/platform/honeybadger/alerting-rules/app.rules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ spec:
for: 30m
labels:
area: platform
cancel_if_cluster_control_plane_unhealthy: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_status_updating: "true"
Expand Down Expand Up @@ -55,6 +56,7 @@ spec:
for: 30m
labels:
area: platform
cancel_if_cluster_control_plane_unhealthy: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_status_updating: "true"
Expand All @@ -75,6 +77,7 @@ spec:
for: 30m
labels:
area: platform
cancel_if_cluster_control_plane_unhealthy: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_status_updating: "true"
Expand Down
1 change: 1 addition & 0 deletions test/tests/providers/global/platform/honeybadger/alerting-rules/app.rules.test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ tests:
app: cilium
app_version: 1.11.2
area: platform
cancel_if_cluster_control_plane_unhealthy: "true"
cancel_if_cluster_status_creating: "true"
cancel_if_cluster_status_deleting: "true"
cancel_if_cluster_status_updating: "true"
Expand Down