add alerts for alloy-metrics #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…storage.rules.yml
…logging.rules.yaml
…deployment.workload-cluster.rules.yml
…prometheus-operator.rules.yml
…rules/chart.rules.yml
…rules/helm.rules.yml
…s/helm-operations.rules.test.yml
|
Ops-recipe update https://github.com/giantswarm/giantswarm/pull/32043 |
hervenicol
reviewed
Nov 7, 2024
test/tests/providers/global/platform/atlas/alerting-rules/alloy.rules.test.yml
Show resolved
Hide resolved
hervenicol
reviewed
Nov 7, 2024
| cancel_if_cluster_status_creating: "true" | ||
| cancel_if_cluster_status_deleting: "true" | ||
| ## This alert pages if any of the monitoring-agent shard is not running. | ||
| - alert: MonitoringAgentShardsNotSatisfied |
There was a problem hiding this comment.
There's no unit test for this one and its associated inhibition?
There was a problem hiding this comment.
I might have forgotten them
There was a problem hiding this comment.
I added alerts for those :)
hervenicol
reviewed
Nov 7, 2024
helm/prometheus-rules/templates/platform/atlas/alerting-rules/monitoring-pipeline.rules.yml
Show resolved
Hide resolved
hervenicol
reviewed
Nov 7, 2024
test/tests/providers/global/platform/atlas/alerting-rules/alloy.rules.test.yml
Outdated
Show resolved
Hide resolved
hervenicol
reviewed
Nov 7, 2024
test/tests/providers/global/platform/atlas/alerting-rules/alloy.rules.test.yml
Outdated
Show resolved
Hide resolved
…y.rules.test.yml Co-authored-by: Hervé Nicol <[email protected]>
…y.rules.test.yml Co-authored-by: Hervé Nicol <[email protected]>
hervenicol
approved these changes
Nov 8, 2024
|
Do you mind reviewing the opsrecipes again @hervenicol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: giantswarm/roadmap#3590
This PR adds alert for the alloy monitoring component. See Changelog for more context
Checklist
oncall-kaas-cloudGitHub group).