add new loki compactor failing alert #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hervenicol
reviewed
Sep 24, 2024
test/tests/providers/global/platform/atlas/alerting-rules/loki.rules.test.yml
Outdated
Show resolved
Hide resolved
hervenicol
reviewed
Sep 24, 2024
test/tests/providers/capi/capa-mimir/platform/atlas/alerting-rules/mimir.rules.test.yml
Outdated
Show resolved
Hide resolved
….rules.test.yml Co-authored-by: Hervé Nicol <[email protected]>
QuentinBisson
commented
Sep 24, 2024
test/tests/providers/capi/capa-mimir/platform/atlas/alerting-rules/mimir.rules.test.yml
Outdated
Show resolved
Hide resolved
…ules/mimir.rules.test.yml
|
I'll merge and release tomorrow because this will page :D |
QuentinBisson
commented
Sep 25, 2024
helm/prometheus-rules/templates/platform/atlas/alerting-rules/loki.rules.yml
Outdated
Show resolved
Hide resolved
QuentinBisson
commented
Sep 25, 2024
test/tests/providers/global/platform/atlas/alerting-rules/loki.rules.test.yml
Outdated
Show resolved
Hide resolved
QuentinBisson
commented
Sep 25, 2024
test/tests/providers/global/platform/atlas/alerting-rules/loki.rules.test.yml
Outdated
Show resolved
Hide resolved
QuentinBisson
dismissed
hervenicol’s stale review
I updated the alerts after some upstream discussions grafana/loki#14239
hervenicol
reviewed
Sep 25, 2024
helm/prometheus-rules/templates/platform/atlas/alerting-rules/loki.rules.yml
Show resolved
Hide resolved
hervenicol
reviewed
Sep 25, 2024
helm/prometheus-rules/templates/platform/atlas/alerting-rules/loki.rules.yml
Outdated
Show resolved
Hide resolved
hervenicol
reviewed
Sep 25, 2024
helm/prometheus-rules/templates/platform/atlas/alerting-rules/loki.rules.yml
Show resolved
Hide resolved
QuentinBisson
commented
Sep 25, 2024
helm/prometheus-rules/templates/platform/atlas/alerting-rules/loki.rules.yml
Outdated
Show resolved
Hide resolved
hervenicol
reviewed
Sep 25, 2024
test/tests/providers/global/platform/atlas/alerting-rules/loki.rules.test.yml
Outdated
Show resolved
Hide resolved
hervenicol
approved these changes
Sep 25, 2024
….rules.test.yml Co-authored-by: Hervé Nicol <[email protected]>
|
I think they're all fixed, thanks for the review ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards: giantswarm/roadmap#3683
This pull request introduces a new alert for Loki compaction. The alert is designed to notify when the compaction process in Loki did not successfully ran in the last 2 hours. This is crucial for maintaining the performance and reliability of our logging infrastructure.
Checklist
oncall-kaas-cloudGitHub group).