Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecated app labels for ksm metrics #1373

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

QuentinBisson
Copy link
Contributor

@QuentinBisson QuentinBisson commented Sep 23, 2024

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR gets rid of the app=kube-state-metrics in favor of the job=kube-state-metrics label as all clusters have upgraded beyond 18.2

Checklist

@QuentinBisson QuentinBisson self-assigned this Sep 23, 2024
@QuentinBisson QuentinBisson requested review from a team as code owners September 23, 2024 08:12
@TheoBrigitte
Copy link
Member

How do we ensure this does not break any dasboard or alerting rule ?

@QuentinBisson
Copy link
Contributor Author

Marie tested it a while back and all ksm metric have this job label set

@QuentinBisson QuentinBisson force-pushed the remove-deprecated-app-label-for-ksm branch from 76fc7de to d40b85e Compare September 23, 2024 10:35
@QuentinBisson
Copy link
Contributor Author

@TheoBrigitte are you fine with this?

@QuentinBisson QuentinBisson merged commit afa68df into main Sep 23, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the remove-deprecated-app-label-for-ksm branch September 23, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants