Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix falco event alerts #1369

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Fix falco event alerts #1369

merged 2 commits into from
Sep 23, 2024

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/giantswarm/issues/27622#issuecomment-2361520576

This PR replaces the labels.node with labels.hostname in the alert description as the node label does not exist in the metrics

Checklist

@QuentinBisson QuentinBisson self-assigned this Sep 22, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner September 22, 2024 22:31
Copy link
Member

@fhielpos fhielpos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuentinBisson QuentinBisson merged commit 3c25fd2 into main Sep 23, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the fix-falco-event-alerts branch September 23, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants