-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send sloth slos to grafana cloud #1348
Conversation
@giantswarm/team-atlas I would think we can do without the 3d , 1d and so on and only use the 5m ones? |
a1f5c3b
to
0c218a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review the queries in detail, but the recorded series LGTM.
I don't know for sure, why other sli_error:ratio_rate*
series except aggregation:slo:sli_error:ratio_rate5m
would be needed.
It actually makes sensé, i'll remove them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.
Towards: https://github.com/giantswarm/giantswarm/issues/31098
This PR creates aggretation for sloth slos so we do not have too high cardinality based on pod, node and instance labels for instance. I will try them out on a test installation first to see the load
Checklist
oncall-kaas-cloud
GitHub group).