-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add MimirHPANeedsToBeScaledUp alert #1340
Conversation
@QuantumEnigmaa should we change this to make it work for Loki also ? |
I think we can do that later. Let's merge this one and the loki one first so that we have those enabled asap and then let's create an issue to refactor this so that we can discuss how we want to do it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you add UTs ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM apart from missing tests :)
Towards: https://github.com/giantswarm/giantswarm/issues/31385
This PR adds
MimirHPANeedsToBeScaledUp
alert in order to detect when an HorizontalPodAutoscaler in the mimir namespace has reached its maximum capacity; meaning replicas are maxed out and resources usage is above targets.For this alert I used the
kube_horizontalpodautoscaler_*
metrics provided by Kubernetes: