Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign alerts on core components directly to turtles #1328

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Conversation

weseven
Copy link
Contributor

@weseven weseven commented Aug 21, 2024

Towards giantswarm/roadmap#2728 / https://github.com/giantswarm/giantswarm/issues/31439

This PR assigns alerts on basic components to turtles directly.

Checklist

@weseven weseven marked this pull request as ready for review August 21, 2024 08:26
@weseven weseven requested a review from a team as a code owner August 21, 2024 08:26
@weseven weseven requested a review from a team August 21, 2024 08:26
@fiunchinho
Copy link
Member

These all look good. Why don't we move all of the alerts on the turtles folder though? If they don't belong to turtles, they should be moved to a different folder. But if they do, I believe turtles should get paged by it.

@weseven weseven merged commit 433935b into main Aug 21, 2024
7 checks passed
@weseven weseven deleted the update-team-labels branch August 21, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants