Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort out shared alerts ownership #1232

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR gets rid of the shared alerts and move them to their proper owners

Checklist

@QuentinBisson QuentinBisson self-assigned this Jun 11, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner June 11, 2024 10:23
@QuentinBisson QuentinBisson requested review from a team as code owners June 11, 2024 10:25
@QuentinBisson QuentinBisson force-pushed the get-rid-of-shared-alerts branch 3 times, most recently from 8fc75f8 to 9848718 Compare June 11, 2024 11:39
@QuentinBisson QuentinBisson force-pushed the get-rid-of-shared-alerts branch from 9848718 to 58493a2 Compare June 11, 2024 11:50
@QuentinBisson QuentinBisson merged commit a1161ea into main Jun 11, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the get-rid-of-shared-alerts branch June 11, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants