Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dex absent query for mimir #1231

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: https://github.com/giantswarm/...

This PR fixes the dex alert using absent for mimir and fixes the promtool_ignore files and codeowners

Checklist

* Fix some shared alert ownership

Signed-off-by: QuentinBisson <[email protected]>

* Update helm/prometheus-rules/templates/kaas/turtles/alerting-rules/kubelet.rules.yml

---------

Signed-off-by: QuentinBisson <[email protected]>
Signed-off-by: QuentinBisson <[email protected]>
@QuentinBisson QuentinBisson self-assigned this Jun 11, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner June 11, 2024 08:32
@QuentinBisson QuentinBisson requested a review from a team June 11, 2024 08:32
@marieroque
Copy link
Contributor

I'm not sure it was necessary as Dex is running on MC only.

@QuentinBisson
Copy link
Contributor Author

But it is because otherwise we're missing the pipeline label :)

@QuentinBisson QuentinBisson merged commit ff29140 into main Jun 11, 2024
7 checks passed
@QuentinBisson QuentinBisson deleted the fix-dex-absent-query-for-mimir branch June 11, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants