-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mimir ingester alerts #1229
Conversation
Aren't we allowed to use aggregating function with the |
helm/prometheus-rules/templates/platform/atlas/alerting-rules/mimir.rules.yml
Outdated
Show resolved
Hide resolved
aaba61b
to
f959d26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we not have a scale up/down ops-recipe that you wrote?
We do indeed ! Updated the ops recipe annotation with it. |
test/tests/providers/capi/capa-mimir/platform/atlas/alerting-rules/mimir.rules.test.yml
Outdated
Show resolved
Hide resolved
dceca5a
to
1fa8a58
Compare
1fa8a58
to
5217bfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Towards: https://github.com/giantswarm/giantswarm/issues/30834
This PR adds 2 alerting rules for mimir which will page when the mimir-ingester pods will consume too much or very few resources (whether it's memory or cpu) so that the oncall will be notified that he or she needs to scale the ingester statefulset accordingly.
Note that the values for scaling up and down were not chosen based on known facts.
Checklist
oncall-kaas-cloud
GitHub group).