Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mimir ingester alerts #1229

Merged
merged 7 commits into from
Jun 13, 2024
Merged

Add mimir ingester alerts #1229

merged 7 commits into from
Jun 13, 2024

Conversation

QuantumEnigmaa
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa commented Jun 10, 2024

Towards: https://github.com/giantswarm/giantswarm/issues/30834

This PR adds 2 alerting rules for mimir which will page when the mimir-ingester pods will consume too much or very few resources (whether it's memory or cpu) so that the oncall will be notified that he or she needs to scale the ingester statefulset accordingly.

Note that the values for scaling up and down were not chosen based on known facts.

Checklist

@QuantumEnigmaa QuantumEnigmaa self-assigned this Jun 10, 2024
@QuantumEnigmaa QuantumEnigmaa requested a review from a team as a code owner June 10, 2024 13:52
@QuantumEnigmaa
Copy link
Contributor Author

Aren't we allowed to use aggregating function with the by in unit tests ?

@QuantumEnigmaa QuantumEnigmaa force-pushed the add-mimir-ingester-alerts branch from aaba61b to f959d26 Compare June 10, 2024 15:03
Copy link
Contributor

@QuentinBisson QuentinBisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we not have a scale up/down ops-recipe that you wrote?

@QuantumEnigmaa
Copy link
Contributor Author

Do we not have a scale up/down ops-recipe that you wrote?

We do indeed ! Updated the ops recipe annotation with it.

@QuantumEnigmaa QuantumEnigmaa force-pushed the add-mimir-ingester-alerts branch from dceca5a to 1fa8a58 Compare June 11, 2024 16:03
@QuantumEnigmaa QuantumEnigmaa force-pushed the add-mimir-ingester-alerts branch from 1fa8a58 to 5217bfa Compare June 11, 2024 16:48
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QuantumEnigmaa QuantumEnigmaa merged commit fda1162 into main Jun 13, 2024
7 checks passed
@QuantumEnigmaa QuantumEnigmaa deleted the add-mimir-ingester-alerts branch June 13, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants