Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atlas alerts with pint #1173

Merged
merged 4 commits into from
May 14, 2024
Merged

Fix atlas alerts with pint #1173

merged 4 commits into from
May 14, 2024

Conversation

QuentinBisson
Copy link
Contributor

Before adding a new alerting rule into this repository you should consider creating an SLO rules instead.
SLO helps you both increase the quality of your monitoring and reduce the alert noise.


Towards: giantswarm/roadmap#3318

This PR fixes atlas alerts with pint

Checklist

@QuentinBisson QuentinBisson self-assigned this May 13, 2024
@QuentinBisson QuentinBisson requested a review from a team as a code owner May 13, 2024 21:36
Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

2 remarks:

  • that's not a lot 😁
  • the pint-aggregations target does more than aggregations. But I'm not sure I should update this, as the errors is fires make sense.

@QuentinBisson
Copy link
Contributor Author

I quite like pint-aggregations for now and we later enforce the full one :)
There are a few more that i'll try to fix but they requires rewriting the alerts a bit more because they use absent IIRC

@QuentinBisson
Copy link
Contributor Author

@hervenicol do you want to take another look with the remaining changes?

Copy link
Contributor

@hervenicol hervenicol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@QuentinBisson QuentinBisson merged commit 3b56325 into master May 14, 2024
6 checks passed
@QuentinBisson QuentinBisson deleted the fix-atlas-alerts-with-pint branch May 14, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants